That's a merge commit and the credit for the merge goes for the release manager. You can see that it is a merge commit because it has 2 parents (you can see that in the github interface), 1d87e12 <https://github.com/sagemath/sage/commit/1d87e12a9a74f7cc6aef56aa63fad3595274efdf> + c53aeb8 <https://github.com/sagemath/sage/commit/c53aeb800c337f86c5ef374ceb58a578c69d2b33>
Second commit is your commit and credited to you and the first is the develop branch head at the time. If you look at git blame in github, it gives your commit not the merge commit. https://github.com/sagemath/sage/blame/4c8db6be91bf8a2809173ea21cce2e28350d188d/build/pkgs/csdp/type On Fri, Apr 15, 2016 at 6:20 PM, Dima Pasechnik <[email protected]> wrote: > > > On Friday, April 15, 2016 at 11:01:54 AM UTC+1, Dima Pasechnik wrote: >> >> >> >> On Friday, April 15, 2016 at 10:48:06 AM UTC+1, Isuru Fernando wrote: >>> >>> That's probably because you don't have your gmail address linked to your >>> github account. You can either add your gmail address as a secondary email >>> account to github or add a .mailmap file to all the github repos you >>> contribute to. >>> >> >> I've just made my gmail address (the one I use for contributions to sage, >> too) as public on github, but >> it did not seem to make any difference. >> >> >>> Isuru Fernando >>> >>> On Fri, Apr 15, 2016 at 3:05 PM, Dima Pasechnik <[email protected]> >>> wrote: >>> >>>> There is an ongoing discussion on modularisation, and one argument for >>>> was that it's hard to see contributions to Sage, as opposed to a separate >>>> smaller project. I pointed out to >>>> >>>> https://github.com/sagemath/sage/graphs/contributors >>>> >>>> which seem to show all the contributions, and then I noticed that I am >>>> not even listed there, whereas I surely contributed few hundred commits and >>>> few thousand lines of code! How is it possible that some contributors are >>>> hidden? Is it because they are not added to some manually controlled list? >>>> >>> > it seems to be a different story: there are lots of commits by me that are > merged by the release manager, e.g. > > https://github.com/sagemath/sage/commit/4c8db6be91bf8a2809173ea21cce2e28350d188d > and thus are not visible on github, apparently. > > Any ideas why some animals are more equal than the others? Just wondering. > Not that it matters for me personally, but I imagine that people on the > corresponding job market would like their commits to be clearly visible. > > Dima > > > > > >> >>>> Thanks, >>>> Dima >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "sage-devel" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at https://groups.google.com/group/sage-devel. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
