I am (still) a strong -1 on this. ``self`` is a perfectly well-defined concept in Python and is often more concise and readable. It also works better with subclasses that have different names, e.g., lattice vs poset. Granted, this is not a very strong point because one should know a lattice is a poset.
Best, Travis On Wednesday, May 17, 2017 at 10:25:30 AM UTC-5, Daniel Krenn wrote: > > On 2017-05-17 17:17, Jeroen Demeyer wrote: > > On 2017-05-17 17:10, Daniel Krenn wrote: > >> I find this perfectly fine. I personally would write "Return whether > >> this lattice is contained in the other lattice", but I do not find any > >> need to include ``self`` in the one-line description. > > > > Well, in general, sentences containing too many words like "this", > > "that", "it", "the $thing", ... are hard to understand. Perhaps the > > is_sublattice() example I gave might be acceptable, but I wouldn't push > > it much further. > > To clearify, I would never use "this" alone, but "this lattice" in the > one-line description seems to be clear where it refers to. (...and I do > not have a problem, if there is a "self" somewhere, but in general the > rule should be not to use it (except if it helps to clearify)) > > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
