I think tying it in with TestSuite(foo).run() is a good idea, but we probably don't want to store pickles for every one (since test suites can be run for multiple elements of the same type). Maybe check to see if a pickle has already been created for a given class, and if not, create one? David
On Sun, Oct 29, 2017 at 6:14 PM, Travis Scrimshaw <tsc...@ucdavis.edu> wrote: > > > On Monday, October 30, 2017 at 5:46:49 AM UTC+10, Jeroen Demeyer wrote: >> >> On 2017-10-29 20:22, Simon King wrote: >> > As part of the release process of a new version of SageMath, >> > a new version of the pickle jar is created by some patchbots >> > on m different machines and replaces the m oldest versions of >> > the pickle jar. >> >> That's the easy part. The hard part is deciding what to put in the >> pickle jar and how to test that the pickles still work. If we don't have >> good ideas for the latter, the pickle jar is pointless. >> > > What about any object that does a TestSuite(foo).run()? This guarantees > that it pickles (assuming it is not skipping that test) and is an object > that someone would create. Usually when those are marked as "# long time", > it is the tests that take a long time (say, iterated over 1000 objects) > rather than creation and (un)pickling. > > Best, > Travis > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
