Hi Erik,

On 2019-11-08, E. Madison Bray <erik.m.b...@gmail.com> wrote:
> Just to clarify, once more (and please reread my earlier message in
> this thread regarding what a "DESTDIR install" is and why that is
> used),

This does not clarify it to me at all, I'm afraid. To start with,
in my very simple mind, I can not intuitively grasp that an
spkg-install script can possibly support a DESTDIR install if the
word "DESTDIR" does not appear in the spkg-install script.

> ...  This allows sage-spkg, the script that actually
> handles building/installing SPKGs, to look in the $SAGE_DESTDIR
> directory that is created as a temporary installation root for the
> package, and generate a list of files that is installed by the package
> [2].

Do I understand correctly that sage-spkg creates a temporary directory
and assigns the environment variable DESTDIR to it, then spkg-install
does its job, and *if* all installation steps done in spkg-install take
the DESTDIR environment variable into account then the installation
is correctly staged there before it is transferred from there to its
final destination? And the content of the json file is obtained from
the contents of the stage area before it is erased?

If that's the case then I'm confident that it should work to replace "$MAKE
install" with "sdh_make_install".

While we are at it: Currently, for building the package's documentation,
I use "$MAKE html" followed by some "cp -r" to copy the resulting html
files to $SAGE_SHARE/doc/p_group_cohomology. I guess this needs to be
fixed (in the sense of "rather use sdh_*) as well

I opened #28711 for it.

Best regards,
Simon

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/qq4ot1%2462r3%241%40blaine.gmane.org.

Reply via email to