On Apr 8, 1:10 pm, William Stein <[email protected]> wrote:
> On Wed, Apr 8, 2009 at 1:06 PM, John H Palmieri <[email protected]>
> wrote:
>
> > I'll mark mine as a duplicate. Go ahead with your patch.
>
> Neither Justin nor I have a patch, and I don't think either of us are
> working on one.
Justin posted on his ticket "I'll attach a patch when the testing is
complete (or try again if testing fails)." It sounded from this and
earlier comments on the ticket as though he had a patch and it was
equivalent to mine.
> I posted this on your patch, which slows str down by a factor of 12
> (in this example):
>
> Needs work. There is a *very good* reason that there is a str method
> for GF(2) -- it's for speed! Check this out:
> {{{
> BEFORE YOUR PATCH:
> sage: a = random_matrix(GF(2),1000)
> sage: time b = a.str()
> CPU times: user 0.41 s, sys: 0.01 s, total: 0.42 s
> Wall time: 0.42 s}}}
>
> {{{
> AFTER YOUR PATCH:
> sage: a = random_matrix(GF(2),1000)
> sage: time b = a.str()
> CPU times: user 5.02 s, sys: 0.86 s, total: 5.88 s
> Wall time: 5.89 s
>
> }}}
So this means duplicating the subdivisions part of the general matrix
str function for the mod 2 case?
John
--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-support
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---
