Hi Nathann, Thanks for fixing it! :) I forgot the issue so my reply is late.
I looked at the patch you produced. I think it's fine except for that I would prefer the "algorithm" keyword-argument to be placed at the end of the argument list for backward compatibility. Best regards, Jan On Oct 29, 11:15 am, Nathann Cohen <[email protected]> wrote: > Hellooooooooooo again !!! > > I finally wrote this patch, available there : > > http://trac.sagemath.org/sage_trac/ticket/11961 > > Though the two algorithms are very similar, I thought it better to > split it into two different parts, so that one can understand better > how each of them works without having to bear with "if algorithm == A" > every second line. Two implementations are now available, two are > checked before being returned, both pass all tests. We should be on > the safe side, now :-D > > Thank you for your help !! :-) > > Nathann -- To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-support URL: http://www.sagemath.org
