#3857: [with another new patch; needs review] BinaryQF_reduced_representatives
in
binary_qf.py produces extra unreduced forms
---------------------------+------------------------------------------------
Reporter: choldsworth | Owner: NilsSkoruppa
Type: defect | Status: new
Priority: major | Milestone: sage-3.1.2
Component: number theory | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by NilsSkoruppa):
* owner: was => NilsSkoruppa
* summary: [with new patch; needs review]
BinaryQF_reduced_representatives in
binary_qf.py produces extra unreduced forms =>
[with another new patch; needs review]
BinaryQF_reduced_representatives in
binary_qf.py produces extra unreduced forms
Comment:
The last patch seemed to be OK. However, I noticed that the bounds for the
search region for reduced forms was not optimal. I inserted the optimal
bounds and modified the loop logic accordingly, and I gained a speedup of
a factor around 10.
Before:
{{{
sage: timeit( 'BinaryQF_reduced_representatives(-998995)')
5 loops, best of 3: 5.52 s per loop
}}}
After:
{{{
sage: timeit( 'BinaryQF_reduced_representatives(-998995)')
5 loops, best of 3: 547 ms per loop
}}}
Doctest runs successfully and I tested 1000 discriminants with 6 digits
each, compared to the corresponding results produced by the last patch and
compared number of produced forms with Hurwitz class numbers in gp. I
think its OK now. Ready for being reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3857#comment:7>
SAGE <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
