#3857: [with another new patch; needs review] BinaryQF_reduced_representatives 
in
binary_qf.py produces extra unreduced forms
---------------------------+------------------------------------------------
 Reporter:  choldsworth    |        Owner:  NilsSkoruppa
     Type:  defect         |       Status:  new         
 Priority:  major          |    Milestone:  sage-3.1.2  
Component:  number theory  |   Resolution:              
 Keywords:                 |  
---------------------------+------------------------------------------------
Comment (by cremona):

 Thanks for the review and great improvement (improved lower bound for b).

 I applied all three patches (that is, all but the first attached to this
 ticket) to 3.1.2.alpha4 successfully, and all doctests in
 sage.quadraticforms pass.  Nils's testing vs. gp was a very good idea, so
 I think we can be confident of this.

 I vote for this to be adopted, and hope the editor will not feel the need
 to get in a new reviewer (so far, each reviewer has vastly improved the
 previous code, but I don't think we can hope for that to happen again!)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3857#comment:8>
SAGE <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to