#3943: [with patch, not ready for review] pydesign patch
---------------------------+------------------------------------------------
Reporter: wdj | Owner: wdj
Type: enhancement | Status: new
Priority: major | Milestone: sage-combinat
Component: combinatorics | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Comment (by mabshoff):
Replying to [comment:8 wdj]:
> > Since this requires an spkg I see little possibility for
>
> Huh?? What spkg??
Ok, taking a closer look I see that you copy some substantial amount of
code from that Python code base. It seems to duplicate a bunch if things
already in Sage in one form or another, i.e.
* def binomial_new(n, k)
* def int_div
The version number code is more than ugly and uses IMHO rather non-
standard tags, i.e. why the external CVS version?
> This is (AFAIK) pure Sage/python. I stripped out the majority of the
original pydesign code and rewrote it. It does have one (very short)
method which outputs the design in xml. Are you suggesting to delete that
method? It does not communicate in xml (though I think the original
pydesign has that option) since I stripped that part out. I did leave the
xml output method (which I partially wrote) in.
Then why add the XML method? Is that some kind of standard that is
actually used by other code? As rlm originally pointed out: If you turn 7
bits of info into a couple dozen lines of ASCII the efficiency goes right
out of the window and it isn't exactly human readable.
This ticket also does not belong to the sage-combinat milestone unless you
plan to submit the code via the sage-combinat patch server.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3943#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
