#4120: [with patch, needs review] New code for binary quadratic forms
-------------------------+--------------------------------------------------
Reporter: justin | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.1.3
Component: algebra | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Comment (by cremona):
I am planning to review this, which looks pretty good. First, some
preliminary questions/comments:
* I see that we now have some, but not all, support for indefinite
forms. (e.g. no equivalence testing, no class number). Why not use pari
interface for those, at least until we do our own? (I would have thought
that pari was pretty efficient for these things).
* Your action of 2x2 matrices is a left action. Do we want to allow
users to use a right action (say, by having RMul and LMul with Mul an
alias for one of them)?
* Your action includes multiplication by det(A). Now there are lots
of application for this code, some will like that and some will want
something else. So why don't we have another parameter for Mul() which is
the power of the determinant to be used. Personally I would set the
default to 0 but if you wanted it to be 1 (as in your code) I could live
with that.
* I still think that quite a lot of the functionality could be
factored out into a more general binary form class, but that can be done
later by someone (e.g. me) who uses higher degree forms.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4120#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
