#4120: [with new patch, needs review] New code for binary quadratic forms
-------------------------+--------------------------------------------------
Reporter: justin | Owner: justin
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.1
Component: algebra | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by cremona):
* summary: [with patch, needs review] New code for binary quadratic
forms => [with new patch, needs review] New
code for binary quadratic forms
Comment:
My patch sage-trac4120new.patch combines the three earlier ones and adds
the following:
* Fixing various bugs and typos
* Sorting out a lot of formatting issues in doctests
* Adds some new functions
* Renames Mul to {{{__mul__}}} so one can say Q*M to apply matrix M to
form Q
Regarding the latter I relented and removed the scale parameter; since
the det is either +1 or -1 I am happy with multiplying (or dividing) by
the determinant.
Issues do remain:
* The various transform function which return a new form Q and a
transform T really must satisfy self.T==Q, but they don't. Hence the
commented out assertions.
* We must decide whether we are talking about weak or strict
equivalence (GL or SL(2,ZZ)). At the moment it is hard to tell which.
* For indefinite forms there are several different notions of
"reduced". OK to to stick to one, but we should make this explicit.
* The class number function looks inefficient to me, it should be
replaced by the fast code by Skoruppa to list reduced forms (in the
definite case at least).
That's all I can remember, but this will need more work before it can go
in.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4120#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
