#4286: [with patch, needs review] minor improvements to old integer code
------------------------------+---------------------------------------------
Reporter: robertwb | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone: sage-3.2
Component: basic arithmetic | Resolution:
Keywords: |
------------------------------+---------------------------------------------
Comment (by robertwb):
Thanks for looking at this. I've attached a new patch that should address
your comments. The type checking has been pulled out of the main loop
which addresses 1 and 2, which was actually an issue in the old code as
well. (Note that isinstance will be a fast typecheck in the next release
of Cython).
As for (3), there is no reason to put _sig_on/_sig_of around mpz_cmp_ui.
These signal handlers are used for long-running code (where one wants to
be able to intercept control-C) or code that might raise other
signals/abort. mpz_cmp_ui is not such a function (in fact, it's a simple
macro).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4286#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
