#4286: [with patch, positive review] minor improvements to old integer code
------------------------------+---------------------------------------------
Reporter: robertwb | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone: sage-3.2
Component: basic arithmetic | Resolution:
Keywords: |
------------------------------+---------------------------------------------
Changes (by GeorgSWeber):
* summary: [with patch, needs review] minor improvements to old integer
code => [with patch, positive review] minor
improvements to old integer code
Comment:
Thanks for cleaning up this old code.
The following very minor issues do certainly not prevent me from giving
this patch "as is" a positive review, but I thought I should write them
down nevertheless:
4. By the patch file, only "def LCM_list" becomes "cpdef LCM_list". One
might also change "def GCD_list" into "cpdef GCD_list", at least for
3.1.3.rc0 (which is the youngest version I currently have and where this
is otherwise not the case), if only for consistency. (I do not know enough
about the difference between "def" and "cpdef" yet, but I do trust you
there.)
5. Again for consistency (or beauty?) only, one could make the two lines
2129/2130
{{{
cdef Integer z
z = PY_NEW(Integer)
}}}
into the one line
{{{
cdef Integer z = <Integer>PY_NEW(Integer)
}}}
(And again I do not enough about using "<Integer>" or not as a type
qualifier, but yet again I trust you there.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4286#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
