#4256: [with patch, needs work] polyhedral improvements: Schlegel diagrams,
standard polytopes, multiplication, polars
---------------------------------+------------------------------------------
 Reporter:  mhampton             |        Owner:  mhampton
     Type:  enhancement          |       Status:  new     
 Priority:  minor                |    Milestone:  sage-3.2
Component:  geometry             |   Resolution:          
 Keywords:  polytopes, geometry  |  
---------------------------------+------------------------------------------
Changes (by anakha):

  * summary:  [with patch, needs review] polyhedral improvements: Schlegel
              diagrams, standard polytopes, multiplication,
              polars => [with patch, needs work] polyhedral
              improvements: Schlegel diagrams, standard
              polytopes, multiplication, polars

Comment:

 The ambient_dim function overwrites the content self._dim thus making
 dim() return a wrong answer:

 {{{
 sage: p = Polyhedron(vertices = [[0,0,1]])
 sage: p.dim()
 0
 sage: p.ambiant_dim()
 3
 sage: p.dim()
 3
 }}}

 In the vertex_adjacency_matrix() docstring, maybe you should use 'binary'
 rather than '0/1'

 In render_solid(), since you now have ambient_dim(), why not use it?  It
 could replace the ugly test I put there.

 Also for the 'special' polyhedron creation methods, it could be good to
 reuse the approach taken for graphs, where you have the Graph class and an
 instance of a special class called graphs where you have building methods
 for most interesting types of graphs.

 The first item is a must-fix, the other three would be nice, but are not
 stricly essential.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4256#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to