#4370: [with patch, needs work] Add ability to clone the doc repository
---------------------------+------------------------------------------------
Reporter: cremona | Owner: GeorgSWeber
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.2.1
Component: documentation | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by GeorgSWeber):
* summary: [with patch, needs review] Add ability to clone the doc
repository => [with patch, needs work] Add
ability to clone the doc repository
Comment:
Hi Michael,
thanks for the review!
> 4370-sage_library.patch should go to its own ticker since it is
independent.
Done, it is now #4441. I also moved the congroup.py patch away to #4442.
>I would also not per default build the Sage documentation on clone
OK. I will address that in an update.
> - we do not do this for the sage library repo itself.
You're wrong here. See lines 68-91 of the "sage-clone" script, where
explicitly "sage -b branch" is called. But let's clone the doc dir without
(re-)build, OK.
> I can't see seem to fine the alleged possibility to clone the sage-
scripts repo. Either way, I would not recommend that we allow this since
there are numerous binaries in the bin directory and switching back and
forth between various bin directories can cause subtle bugs at runtime.
Ah, misunderstanding! I meant that the patch-files attached are to applied
themselves to these three different repos, not more. I totally agree that
cloning "$SAGE_ROOT/local/bin" would be a bad idea. But the content of the
patch(es) did not and will not allow for that.
>Another thing I would like to wait for is the switch to the ReST
documentation before we allow cloing the doc repo.
Well. It might be helpful for the ReST documentation deployment.
>In the end I don't think this should be merged into 3.2 :(.
Fine, at least for me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4370#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
