#4443: [with patch, with review, needs work] Massive prime_range speedup, arith*
files cleanup
------------------------------+---------------------------------------------
Reporter: craigcitro | Owner: craigcitro
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.2
Component: basic arithmetic | Resolution:
Keywords: |
------------------------------+---------------------------------------------
Changes (by cremona):
* summary: [with patch, needs review] Massive prime_range speedup,
arith* files cleanup => [with patch, with
review, needs work] Massive prime_range
speedup, arith* files cleanup
Comment:
First things first: patch applies cleanly to 3.2.alpha2, but -testall
gives this:
{{{
The following tests failed:
sage -t devel/sage/sage/calculus/calculus.py
sage -t devel/sage/sage/tests/book_stein_modform.py
sage -t devel/sage/sage/tests/book_stein_ent.py
sage -t devel/sage/sage/schemes/elliptic_curves/sha_tate.py
sage -t devel/sage/sage/schemes/elliptic_curves/ell_tate_curve.py
sage -t
devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py
sage -t devel/sage/sage/modular/abvar/abvar.py
sage -t devel/sage/sage/modular/modform/eis_series.py
sage -t devel/sage/sage/modular/modform/ambient.py
sage -t devel/sage/sage/modular/modform/hecke_operator_on_qexp.py
sage -t devel/sage/sage/modular/modform/vm_basis.py
sage -t devel/sage/sage/modular/modform/j_invariant.py
sage -t devel/sage/sage/modular/modform/space.py
sage -t devel/sage/sage/modular/modform/cuspidal_submodule.py
sage -t devel/sage/sage/modular/modform/element.py
}}}
which are probably all trivial but need to be fixed.
I find a patch like this quite hard to review, since it combines a lot of
moving of chunks of code around (certainly a good idea here) with all the
trivial changes which that leads to; and some real bug-fixes. When
scanning the patch one sees lots of large blue and red hunks (which may or
may not hide significant code changes), and a lot of trivial changes, and
buried in there is the "real meat".
One thing I could not work out easily was exactly how my earlier changes
to lcm and gcd caused the slow-down!
Anyway this is a basically positive review, and I'll be happy to look at
it again.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4443#comment:8>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
