#4392: [with patch, positive review] smallest_integer() is broken
--------------------------------+-------------------------------------------
Reporter: cremona | Owner: cremona
Type: defect | Status: closed
Priority: major | Milestone: sage-3.2
Component: number theory | Resolution: fixed
Keywords: number field ideal |
--------------------------------+-------------------------------------------
Comment (by mabshoff):
Replying to [comment:8 cremona]:
> Replying to [comment:6 mabshoff]:
> > Merged sage-trac4392-new.patch and sage-4392-typo.patch in Sage
3.2.rc1.
> >
> > John: The folded(?) patch was a diff a not a "proper" mercurial patch,
so the credit in the log does not reflect your authorship. Please make
sure to export patches.
>
> Sorry about that. I had tried to make it easier, by using mercurial
queues to merge my three earlier patches. But clearly I am not doing it
right. Every time I uses queues I read the entire documentation from
beginning to end, and think I understand it, but clearly I don't since
every time I mess it up. John
Well, I am more concerned about me getting credit for a patch I did not
write. The solution to your problem is to export the que patch.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4392#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
