#4583: [with patch; positive review] implement "sage -t --only-optional"
-------------------------+--------------------------------------------------
Reporter: was | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.1
Component: doctest | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by mabshoff):
* summary: [with patch; needs review] implement "sage -t --only-
optional" => [with patch; positive review]
implement "sage -t --only-optional"
Comment:
I really like this patch :)
So far everything I tried works well. The patch seems to expose some small
issues like the ones below:
{{{
age -t -only-optional=magma
devel/sage/sage/rings/number_field/number_field.py
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha0/devel/sage/sage/rings/number_field/number_field.py",
line 2452:
sage: x = polygen(QQ)
Expected:
Galois group Transitive group number 2 of degree 3 of the Number Field
in a with defining polynomial x^3 + 2*x + 1
Got nothing
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha0/devel/sage/sage/rings/number_field/number_field.py",
line 2455:
sage: NumberField(x^3 + 2*x + 1, 'a').galois_group(algorithm='magma')
# optional - magma
Expected:
Galois group Transitive group number 2 of degree 3 of the Number Field
in a with defining polynomial x^3 + 2*x + 1
Got:
verbose 0 (501: permgroup_named.py, __init__) Warning: Computing with
TransitiveGroups requires the optional database_gap package. Please
install it.
Galois group Transitive group number 2 of degree 3 of the Number Field
in a with defining polynomial x^3 + 2*x + 1
**********************************************************************
}}}
I.e. the last test should depend on Magma and database_gap. But all these
little bugs can be addressed via follow up patches, so I am giving this
patch a positive review.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4583#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
