#4282: [with patch, needs work] symbolic minpoly
-------------------------+--------------------------------------------------
Reporter: robertwb | Owner: burcin
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.1
Component: calculus | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by was):
* summary: [with patch, needs review] symbolic minpoly => [with patch,
needs work] symbolic minpoly
Comment:
Referee report:
I applied the patch to sage-3.2.1.alpha2.
1. A doctest fails in calculus.py:
{{{
sage -t devel/sage/sage/calculus/calculus.py
**********************************************************************
File "/home/was/build/sage-3.2.1.alpha1/devel/sage-
main/sage/calculus/calculus.py", line 1337:
sage: sin(pi/7).minpoly()
Exception raised:
Traceback (most recent call last):
File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/home/was/build/sage-3.2.1.alpha1/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/home/was/build/sage-3.2.1.alpha1/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_43[5]>", line 1, in <module>
sin(pi/Integer(7)).minpoly()###line 1337:
sage: sin(pi/7).minpoly()
File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-
packages/sage/calculus/calculus.py", line 1345, in minpoly
return QQbar(self).minpoly()
File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-
packages/sage/rings/qqbar.py", line 663, in __call__
return x._algebraic_(QQbar)
File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-
packages/sage/calculus/calculus.py", line 6471, in _algebraic_
exp_ia = exp(SR(-1).sqrt()*operand)._algebraic_(QQbar)
File "/home/was/build/sage-3.2.1.alpha1/local/lib/python2.5/site-
packages/sage/calculus/calculus.py", line 6460, in _algebraic_
rat_arg = (operand.imag()/(2*self.parent().pi()))._rational_()
AttributeError: 'SymbolicExpressionRing_class' object has no attribute
'pi'
**********************************************************************
1 items had failures:
1 of 6 in __main__.example_43
***Test Failed*** 1 failures.
For whitespace errors, see the file
/home/was/build/sage-3.2.1.alpha1/tmp/.doctest_calculus.py
[114.8 s]
The following tests failed:
sage -t devel/sage/sage/calculus/calculus.py # 1 doctests failed
}}}
2. This sentence sounds like nonsense:
{{{
1335 NOTE: Failure of this function does not prove self
is
1336 not algebraic.
}}}
3. There are now only three boring tests of symbolic minpoly. All the old
interesting tests are now tests of minpoly_numeric. I think all the
minpoly_numeric tests should *also* be copied to the docstring for minpoly
and tested using the new non-numerical algorithm.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4282#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
