#4535: refactoring in plot/*
----------------------+-----------------------------------------------------
Reporter: mhansen | Owner: mhansen
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.2.1
Component: graphics | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by was):
I really like this patch reading it. But it doesn't apply:
{{{
patching file sage/calculus/desolvers.py
Hunk #1 succeeded at 39 with fuzz 2 (offset 2 lines).
patching file sage/geometry/polyhedra.py
Hunk #1 FAILED at 30
1 out of 1 hunk FAILED -- saving rejects to file
sage/geometry/polyhedra.py.rej
patching file sage/plot/animate.py
Hunk #1 FAILED at 60
Hunk #2 FAILED at 120
Hunk #6 succeeded at 253 with fuzz 2 (offset 14 lines).
2 out of 6 hunks FAILED -- saving rejects to file sage/plot/animate.py.rej
patching file sage/plot/plot.py
Hunk #17 FAILED at 1261
Hunk #18 FAILED at 2349
2 out of 24 hunks FAILED -- saving rejects to file sage/plot/plot.py.rej
abort: patch failed to apply
}}}
Assuming it works, it gets copyright headers, and passes all doctests (in
the whole tree), I will give this a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4535#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
