#4276: [with patch, needs review] move number fields to new coercion, implement
embeddings
----------------------+-----------------------------------------------------
Reporter: robertwb | Owner: robertwb
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.2
Component: coercion | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by mabshoff):
Replying to [comment:18 ncalexan]:
Hi Nick,
> This code is good, it really is, but it's just not tested. I don't have
time right now to test it and I will be sans computer over the Christmas
break.
>
> I have to give this a negative review because I do not believe the
embeddings work in anything more than the trivial situation: two absolute
fields, compatible embeddings into CC.
Ok.
> On the other hand, I have no reservations about the coercion part of
this patch. Are we willing to accept almost certainly broken new
functionality to have valuable infrastructure upgrades?
I would say the answer is to merge this as is and then open follow up
tickets for the problems. Does #4692 address your current concern?
It looks like 3.2.2 will be longer than I have though, so getting this in
now should give us the time needed to straighten this out before release.
Thoughts?
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4276#comment:20>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
