#4681: [with patches, positive review, needs rebase] General Smith normal form
implementation
---------------------------------------+------------------------------------
 Reporter:  davidloeffler              |        Owner:  davidloeffler
     Type:  enhancement                |       Status:  assigned     
 Priority:  major                      |    Milestone:  sage-3.2.2   
Component:  linear algebra             |   Resolution:               
 Keywords:  matrix, smith normal form  |  
---------------------------------------+------------------------------------
Changes (by mabshoff):

  * summary:  [with patches, positive review] General Smith normal form
              implementation => [with patches, positive
              review, needs rebase] General Smith normal form
              implementation

Comment:

 Unfortunately there is a slight reject for trac_4681_part1_smithform-
 consistent.patch:
 {{{
 sage-3.2.2.alpha1/devel/sage$ patch -p1 < trac_4681_part1_smithform-
 consistent.patch
 patching file sage/matrix/matrix2.pyx
 Hunk #1 FAILED at 4549.
 1 out of 1 hunk FAILED -- saving rejects to file
 sage/matrix/matrix2.pyx.rej
 patching file sage/matrix/matrix_integer_dense.pyx
 patching file sage/matrix/symplectic_basis.py
 patching file sage/modular/etaproducts.py
 patching file sage/rings/number_field/number_field_element.pyx
 patching file sage/rings/number_field/number_field_ideal.py
 patching file sage/rings/number_field/order.py
 patching file sage/rings/polynomial/polynomial_element.pyx
 patching file sage/rings/ring.pyx
 }}}

 3.2.2.alpha1 should be out in a couple hours, so please rebase. For the
 record: I want to apply

  * trac_4681_part1_smithform-consistent.patch
  * 4681-docstringfix.patch
  * 4681-more-doctests.patch

 Cheers,

 Michael

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4681#comment:17>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to