#4741: [with patch, positive review, needs rebase] Implement S-integral point
finding for elliptic curves over Q
---------------------------+------------------------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.2
Component: number theory | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by mabshoff):
* summary: [with patch, positive review] Implement S-integral point
finding for elliptic curves over Q => [with
patch, positive review, needs rebase] Implement
S-integral point finding for elliptic curves
over Q
Comment:
Yep, I am seeing the same issue as William:
{{{
mabsh...@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage$
patch -p1 < trac_4741_part_1_rebase.patch
patching file sage/schemes/elliptic_curves/ell_point.py
patching file sage/schemes/elliptic_curves/ell_rational_field.py
Hunk #1 succeeded at 4585 (offset 53 lines).
mabsh...@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage$
patch -p1 < trac_4741_part_2_doctest.patch
patching file sage/schemes/elliptic_curves/ell_rational_field.py
Hunk #1 succeeded at 4669 (offset 53 lines).
mabsh...@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage$
patch -p1 < trac_4741_part_3_prec.patch
patching file sage/schemes/elliptic_curves/ell_point.py
mabsh...@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage$
patch -p1 < trac_4741_part_4_typos.patch
patching file sage/schemes/elliptic_curves/ell_point.py
patching file sage/schemes/elliptic_curves/ell_rational_field.py
Hunk #1 succeeded at 4651 (offset 66 lines).
mabsh...@sage:/scratch/mabshoff/release-cycle/sage-3.2.2.rc0/devel/sage$
patch -p1 --dry-run < trac_4741_part_5_fix3.patch
patching file sage/schemes/elliptic_curves/ell_point.py
patching file sage/schemes/elliptic_curves/ell_rational_field.py
Hunk #1 FAILED at 485.
Hunk #2 FAILED at 509.
Hunk #3 succeeded at 4644 (offset 66 lines).
2 out of 3 hunks FAILED -- saving rejects to file
sage/schemes/elliptic_curves/ell_rational_field.py.rej
patching file sage/schemes/elliptic_curves/kodaira_symbol.py
Hunk #1 FAILED at 78.
1 out of 1 hunk FAILED -- saving rejects to file
sage/schemes/elliptic_curves/kodaira_symbol.py.rej
}}}
So either I am doing something wrong, i.e. merging the wrong patches or
fix3 needs a rebase.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4741#comment:19>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
