#4900: [with patch, needs review] New BSGS point counting on elliptic curves
over
finite fields
-------------------------------------------+--------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4
Component: number theory | Resolution:
Keywords: elliptic curves finite fields |
-------------------------------------------+--------------------------------
Comment (by cremona):
Replying to [comment:2 malb]:
> * it seems the docstring for the option 'all' lacks a mention of 'bsgs'
(it only mentions 'pari' and 'sea'
OK. Actually the 'all' option does not work at all as advertised since
the cached value is used. I had to comment out the cache retrieval lines
to test.
I think a better way of managing this would be for the individual methods
to have separate functions which do _not_ use the cached value (as in the
new functions cardinality_bsgs()) and then the main user function
cardinality() can call whichever version the user wants (but use the
cached value if available; perhaps only if the user does not specify an
algorithm to use).
> * I'm not sure about the current policy w.r.t. renaming stuff ('bsgs'
-> 'pari'). Would this break existing code?
I checked and there's nothing in Sage itself affected. In other places
algorithm=pari is used and it makes more sense to me than to second-guess
what algorithm the current version of pari uses.
> * maybe the debug printing should be handled using {{{verbose()}}}?
> * is the {{{if debug}}} around {{{assert foo}}} necessary?
I have no strong feelings. The assertions are there for debugging
purposes. I prefer this way of commenting lines out; I could delete
them, but then it will be more hassle next time there is a bug.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4900#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
