#4973: [with patch, positive review] rewrite the function __getitem__ in
matrix0.pyx to support slices better, negative indices, and be faster
----------------------+-----------------------------------------------------
Reporter: mabshoff | Owner: jason
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.3
Component: misc | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by craigcitro):
Ah, excellent. In this particular case, we've just done both of those
checks -- the typecheck and the length check -- so I'm going to say we
should stick with the `PyTuple_GET_ITEM` (we also raise an explicit
exception if the length is wrong), but I'm happy to know that in general,
Cython generates such good code.
It'd be nice if Cython skipped the typecheck when it knew the type --
should a ticket be filed on the Cython trac server?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4973#comment:21>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
