#3938: [with patch, with positive review pending minor fixes] coercion framework
converts built-in types to Sage types when it should not
----------------------+-----------------------------------------------------
Reporter: cwitty | Owner: robertwb
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.1
Component: coercion | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Changes (by craigcitro):
* summary: [with patch, needs review] coercion framework converts built-
in types to Sage types when it should not =>
[with patch, with positive review pending minor
fixes] coercion framework converts built-in
types to Sage types when it should not
Comment:
Patch looks good. Thankfully, David folded everything into one patch.
I have two minor issues, and after these are fixed, I'm happy to give this
a positive review.
* There are two long blocks (an `EXAMPLES` and a `TESTS`) that are not
indented correctly.
* There are three functions that are moved and one that is new which need
doctests. (The moved functions don't necessarily have to have them added,
but since it's three functions, it seems worth just adding doctests.)
Once these are done, I'm happy to give this a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3938#comment:13>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
