#4805: [with patch, needs work] S_integral points failure (possible p-adic
precision problem)
----------------------------+-----------------------------------------------
Reporter: cremona | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.4
Component: number theory | Resolution:
Keywords: elliptic curve |
----------------------------+-----------------------------------------------
Changes (by roed):
* cc: roed (added)
* summary: [with patch, needs review] S_integral points failure
(possible p-adic precision problem) => [with
patch, needs work] S_integral points failure
(possible p-adic precision problem)
Comment:
file: ell_point.py
function: has_good_reduction
the docstring has_good_reduction allows P = None, but the code doesn't
(and it's not doctested).
if K is rings.QQ:
pi = P
else:
pi = K.uniformizer(P)
occurs twice (1063 and 1077)
function: padic_elliptic_logarithm
docstring should change to reflect the new default precision
The explanation for the precision should be clarified: it's not the
precision of the result, rather something slightly less. Even better:
change the code so that the answer returned actually has the given
precision. You should also specify whether this precision is relative or
absolute (it's probably absolute). Using "absprec = 20" in the function
arguments would clarify this.
Once the definition of precision is clarified, I think the ValueErrors be
able to be eliminated (if you're trying to return an answer of a given
precision, just increase the precision whenever you would otherwise hit a
ValueError.
file: ell_rational_field.py
function: S_integral_points
The NOTE should be modified to take this patch into account.
line 5103: You shouldn't have bare except blocks. Figure out what kinds
of exceptions you want to catch, and list them explicitly.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4805#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
