#5142: [with patch, needs work] speed up elementary_divisors for sparse integer
matrices?
-----------------------------------------+----------------------------------
Reporter: jhpalmieri | Owner: jhpalmieri
Type: defect | Status: new
Priority: minor | Milestone: sage-3.4.1
Component: linear algebra | Resolution:
Keywords: sparse, elementary_divisors |
-----------------------------------------+----------------------------------
Changes (by AlexGhitza):
* summary: [with patch, needs review] speed up elementary_divisors for
sparse integer matrices? => [with patch, needs
work] speed up elementary_divisors for sparse
integer matrices?
Comment:
The patch looks good; I have three complaints regarding the docstring:
* in the description of the algorithm 'pari', you presumably mean "works
robustly", since "works robustless" doesn't mean anything
* this is a one-line method, and it is pretty self-explanatory, so I
don't think it needs a description of the implementation in the docstring
* the OUTPUT description claims that the method returns a list of int's;
this is not true, since the output is a list of Integer's
I'll very happily give this a positive review once these issues are
resolved. This patch is a good idea and, as John points out, similar
things should be done for other methods for sparse matrices (determinant
is another example). For the record, trying
{{{
sage: A = random_matrix(ZZ, 100, 100, sparse=True)
sage: time e = A.elementary_divisors()
}}}
simply fails with a mysterious !TypeError in the current code, whereas
with the patch applied it works in 1.44 seconds.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5142#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
