#5409: [with patch; needs review] rewrite quaternion algebras -- the current
implementation isn't sufficiently good
-------------------------+--------------------------------------------------
Reporter: was | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4
Component: algebra | Keywords:
-------------------------+--------------------------------------------------
Comment(by tornaria):
Replying to [comment:2 mabshoff]:
I can fix all the doctest failures except
{{{
sage -t devel/sage/sage/structure/sage_object.pyx # 1 doctests
failed
}}}
which I don't know how to deal with.
The fix is two one-liners on top of part6
{{{
diff -r 311c05f56282 sage/rings/arith.py
--- a/sage/rings/arith.py Mon Mar 02 04:52:16 2009 -0500
+++ b/sage/rings/arith.py Mon Mar 02 10:20:29 2009 -0800
@@ -3964,6 +3964,7 @@
1, mod 4, and such that, at most, the only square dividing it is
4.
"""
+ from sage.rings.all import Integer
D = Integer(D)
D = D.squarefree_part()
if D%4 == 1:
diff -r 311c05f56282 sage/rings/ring.pyx
--- a/sage/rings/ring.pyx Mon Mar 02 04:52:16 2009 -0500
+++ b/sage/rings/ring.pyx Mon Mar 02 10:20:29 2009 -0800
@@ -735,7 +735,7 @@
sage: ZpCA(7).is_commutative()
True
sage: A = QuaternionAlgebra(QQ, -1, -3, names=('i','j','k'));
A
- Quaternion algebra with generators (i, j, k) over Rational
Field
+ Quaternion Algebra (-1, -3) with base ring Rational Field
sage: A.is_commutative()
False
"""
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5409#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---