#5409: [with patch; needs review] rewrite quaternion algebras -- the current
implementation isn't sufficiently good
-------------------------+--------------------------------------------------
Reporter: was | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4
Component: algebra | Keywords:
-------------------------+--------------------------------------------------
Comment(by was):
I found a few issues with jvoight's referee patch, which I'm noting here:
* In inner_product_matrix the docs say: "The standard basis 1, i, j, k is
orthogonal, so this matrix is just the diagonal matrix with diagonal
entries 1, a, b, a*b." In the code, though, it's 2,2*a,2*b,2*a*b.
* Line 475 is:
"and j*i=-i*j. K is a field not of characteristic and a,b are nonzero
elements of K"
but it should say "and j*i=-i*j. K is a field not of characteristic 2 and
a,b are nonzero elements of K" (the missing 2).
Otherwise the referee patch from jvoight looks very very good!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5409#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
