#13525: PALP/Laurent Normal Form
-------------------------------+--------------------------------------------
Reporter: sjg10 | Owner: mhampton
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: geometry | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: sjg10 | Merged in:
Dependencies: | Stopgaps:
-------------------------------+--------------------------------------------
Comment (by vbraun):
Very nice! Thanks for tackling this, I always wanted this implemented!
Some minor nitpicks: Whenever you return a list of stuff, its better to
return a tuple (which is immutable).
{{{
def matrix_transformation(self,NewPolytope):
}}}
!CamelCase should only be used for class names, not parameters. Also,
space after comma. Thats just the standard Python code style.
{{{
def lexicographical_order(self,certify=False):
}}}
The name is a bit confusing, how about `permutation_normal_form()` or
something like that?
{{{
def is_isomorphic(self,N,certify=False):
}}}
The linear algebra people will probably object to that kind of isomorphism
check of matrices. How about `is_permutation_of()`?
{{{
By default, in general one can't mix matrices and permutations
}}}
Should be just "in general, ...".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13525#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
