#12943: Tableau_class.__div__, Partition_class.__div__ are checking domination
when they should check inclusion
---------------------------------+------------------------------------------
Reporter: hthomas | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: tableau | Work issues:
Report Upstream: N/A | Reviewers: Mike Hansen
Authors: Hugh Thomas | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by hthomas):
Hi Andrew--
I improved the grammar as you requested. I also realized that I had
somehow gotten things out of order in the tableau patch -- it was checking
that the inputs were sensible after it had started processing them, rather
than before. I fixed this too. I would therefore prefer that you set the
positive review yourself, if you don't mind.
Thanks for reviewing this. I apologize for wasting everyone's time with
this ticket, which is a rather minuscule improvement. I will try to
restrain myself from indulging in similar tidying impulses in the future.
cheers,
Hugh
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12943#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
