#12943: Tableau_class.__div__, Partition_class.__div__ are checking domination
when they should check inclusion
---------------------------------+------------------------------------------
Reporter: hthomas | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: tableau | Work issues:
Report Upstream: N/A | Reviewers: Mike Hansen
Authors: Hugh Thomas | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by andrew.mathas):
Hi Hugh.
The patch looks good. I ran tests with the initial patch -- they passed --
but haven't done retested the patch. The patchbot doesn't seem to want to
run the tests for me either and I am not sure how to make it do so.
Assuming that the tests all pass, I give it a positive review.
Also, I agree with Nicolas and Jeroen that large patches should be avoided
(even though I seem to have mainly large patches in the queue...)
Andrew
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12943#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
