#13130: Ring support for projective space points and morphisms
-----------------------------------------+----------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: algebraic geometry | Resolution:
Keywords: projective space ring | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Ben Hutz | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------+----------------------------------
Comment (by bhutz):
I went to check this on 5.3 and noticed that I had implemented scale_by()
and normalize_coordinates() in class::SchemeMorphism_polynomial. That was
wrong since they should only apply to projective maps. So I've moved those
to SchemeMorphism_polynomial_projective_space.
They modify the _ _polys attribute of the SchememMorphism_polynomial, but
a _ _ attribute is private. Since it makes sense to inherit the polys
attribute, I changed it to ._polys. I checked through the source and found
no place where that created an issue and all tests currently pass.
Also, I noticed that somehow I've created a bunch of
_ 'blank line'
+ 'blank line'
I tried to removed those directly from the patch file and wrecked patch.
If someone could tell me how to get those out of there, I'd like to remove
them.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13130#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
