#13365: Add Semidirect Product Method for Permutation Groups
-------------------------------------------------+--------------------------
       Reporter:  khalasz                        |         Owner:  joyner       
 
           Type:  enhancement                    |        Status:  needs_review 
 
       Priority:  minor                          |     Milestone:  sage-5.4     
 
      Component:  group theory                   |    Resolution:               
 
       Keywords:  groups semidirect product GAP  |   Work issues:               
 
Report Upstream:  N/A                            |     Reviewers:  Benjamin 
Jones
        Authors:  Kevin Halasz                   |     Merged in:               
 
   Dependencies:                                 |      Stopgaps:               
 
-------------------------------------------------+--------------------------

Old description:

> Adds a semidirect product method.
> A generic, top-level method is added to categories/groups.py, which
> simply raises a `NotImplementedError`. This  is then overridden in
> permgroup.py. This method wraps GAP's `SemidirectProduct` function. It is
> implemented so that the calling group is the group acting on an inputted
> normal subgroup.
>
> '''Apply'''
>  1. [attachment:13365_semidirectproduct-v2.2.patch]
>  2. [attachment:trac_13365_reviewer.patch]

New description:

 Adds a semidirect product method.
 A generic, top-level method is added to categories/groups.py, which simply
 raises a `NotImplementedError`. This  is then overridden in permgroup.py.
 This method wraps GAP's `SemidirectProduct` function. It is implemented so
 that the calling group is the group acting on an inputted normal subgroup.

 '''Apply'''
  1. [attachment:13365_semidirectproduct-v2.2.patch]
  2. [attachment:trac_13365_reviewer-v2.patch]

--

Comment (by rbeezer):

 Added a commit message to the reviewer patch and fixed a spelling mistake.
 Maybe it was the same mistake KDC found, but how would we know?

 Kevin - three of us have looked at the reviewer patch now.  But you have
 the final say.  If it looks OK to you, then you can say so here, and flip
 the ticket to positive review, or wait for Ben to do it.  (Do not add me
 as a reviewer or anything, just doing a public service on the reviewer
 patch).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13365#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to