#13516: prime_powers doesn't work with start very well
---------------------------------+------------------------------------------
       Reporter:  kcrisman       |         Owner:  was       
           Type:  defect         |        Status:  needs_work
       Priority:  major          |     Milestone:  sage-5.4  
      Component:  number theory  |    Resolution:            
       Keywords:  beginner       |   Work issues:            
Report Upstream:  N/A            |     Reviewers:            
        Authors:  Kevin Halasz   |     Merged in:            
   Dependencies:                 |      Stopgaps:            
---------------------------------+------------------------------------------
Changes (by dimpase):

  * status:  needs_review => needs_work


Comment:

 Replying to [comment:20 khalasz]:
 > I've made the changes. Let me know what you think!
 I think there is a bug in the code, coming from the fact that
 {{{
 sage: Integer(None)==None
 False
 }}}
 You also should have test cases (doctests) for all the different
 combinations of start/stop, and test them, too. You know that you can run
 Sage so that it tests doctests in a particular file, right?
 E.g. the bug above would have been caught by the proper doctest.
 Also, for some reason you removed the test {{{sage: v =
 prime_powers(10)}}}, but it was there for good reason.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13516#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to