#13236: Elements of a specific rank of a ranked poset
----------------------------------------------+-----------------------------
Reporter: numata | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: poset, combinatorics, sd40 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: NUMATA, Yasuhide | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------+-----------------------------
Comment (by hthomas):
You have "rertuns" in the doc strings (twice).
Examples should be preceded by "EXAMPLES::" (all caps) not "Examples::"
You introduce some lines which have only blank spaces in them. It is
preferable not to do this --- a blank line should consist only of a return
character. (There are places where this convention is not adhered to in
current Sage code. Don't try to fix this in old code, as it is likely to
lead to conflicts with other patches, but it's good practice to follow
this convention when writing new code.)
At the moment, is_ranked is implemented by calling rank_function and
checking whether the result in "None". In order to avoid calling this
method twice, it would probably be better to define r as you do, then
check whether or not it is None yourself.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13236#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
