#5513: [with patch, positive review subject to minor alterations] Enhanced 
support
for number field unit groups
---------------------------+------------------------------------------------
 Reporter:  cremona        |       Owner:  was                    
     Type:  enhancement    |      Status:  new                    
 Priority:  major          |   Milestone:  sage-3.4.1             
Component:  number theory  |    Keywords:  number field unit group
---------------------------+------------------------------------------------

Comment(by cremona):

 I have fixed all the issues raised in the review in the new patch
 trac_5513.patch.  I added a doctest in unit_group.py to show that the
 relative example now works.  I tested all in sage/rings/number_field.

 Apologies for the confusion:  I thought that my new patch (called
 trac_5513.patch) replaced the origianl one because I was using mercurial
 queues, but (as usual) I was wrong.  You need to apply the original
 units.patch and then the new one (trac_5513.patch) which appear twice on
 trac, once with the worng message and once with the right one.  I hope
 that is clear.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5513#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to