#12407: Add the set of PrimitiveGroups
------------------------------------+---------------------------------------
Reporter: trehn | Owner: joyner
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: group theory | Resolution:
Keywords: primitive groups | Work issues:
Report Upstream: N/A | Reviewers: vdelecroix, Volker Braun
Authors: Thomas Rehn | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by vbraun):
* reviewer: vdelecroix => vdelecroix, Volker Braun
Old description:
> This patch implements the finite enumerated set of primitive permutation
> groups of a given degree, and the infinite enumerated set of all
> primitive permutation groups. It is based on the work done in #8500 for
> transitive permutation groups.
>
> This allows a user to do:
> {{{
> sage: PrimitiveGroups(4).cardinality()
>
> sage: for G in PrimitiveGroups(i):
> ... any_test(G) # any test over all primitive groups of a given
> degree
>
> sage: for G in PrimitiveGroups():
> ... other_test(G) # test over all primitive groups
> }}}
> This requires the optional database_gap which contains all the primitive
> permutation groups of degree <= 2499. Therefore, in practice, the
> enumeration stops with a NonImplementedError?
New description:
This patch implements the finite enumerated set of primitive permutation
groups of a given degree, and the infinite enumerated set of all primitive
permutation groups. It is based on the work done in #8500 for transitive
permutation groups.
This allows a user to do:
{{{
sage: PrimitiveGroups(4).cardinality()
sage: for G in PrimitiveGroups(i):
... any_test(G) # any test over all primitive groups of a given
degree
sage: for G in PrimitiveGroups():
... other_test(G) # test over all primitive groups
}}}
This requires the optional database_gap which contains all the primitive
permutation groups of degree <= 2499. Therefore, in practice, the
enumeration stops with a NonImplementedError?
Apply trac_12407_primitive_permutation_groups.patch,
trac_12407_review.patch
--
Comment:
I've added some docstring fixes to follow Sage conventions more closely.
E.g. imperative ("Return") instead of "Returns", indentation, keep line
length finite, .... Also I don't think that we really need an alias
`primitive_id`, just `group_primitive_id` is IMHO enough.
Please have a look at the reviewer patch. Positive review from me for
everything else.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12407#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
