#12407: Add the set of PrimitiveGroups
------------------------------------+---------------------------------------
Reporter: trehn | Owner: joyner
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.5
Component: group theory | Resolution:
Keywords: primitive groups | Work issues:
Report Upstream: N/A | Reviewers: Vincent Delecroix, Volker
Braun
Authors: Thomas Rehn | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Changes (by jdemeyer):
* status: positive_review => needs_work
Comment:
There are various doctest errors:
{{{
sage -t -force_lib devel/sage/sage/groups/perm_gps/permgroup_named.py
**********************************************************************
File "/release/merger/sage-5.5.beta2/devel/sage-
main/sage/groups/perm_gps/permgroup_named.py", line 1515:
sage: PrimitiveGroup(6,5)
Expected:
Traceback (most recent call last):
...
AssertionError: n should be in {1,..,4}
Got:
verbose 0 (1813: permgroup_named.py, cardinality) Warning:
PrimitiveGroups requires the GAP database package. Please install it with
`
`sage -i database_gap``.
[...]
**********************************************************************
File "/release/merger/sage-5.5.beta2/devel/sage-
main/sage/groups/perm_gps/permgroup_named.py", line 1552:
sage: G = PrimitiveGroup(5,1); G
Exception raised:
[...]
AssertionError: n should be in {1,..,None}
**********************************************************************
File "/release/merger/sage-5.5.beta2/devel/sage-
main/sage/groups/perm_gps/permgroup_named.py", line 1569:
sage: G = PrimitiveGroup(5,2); G.group_primitive_id()
Exception raised:
[...]
AssertionError: n should be in {1,..,None}
**********************************************************************
}}}
Besides that, you should not use `assert` for this. Only use "assert" to
check for actual bugs, not for bad user input. If there is any way at all
to reproduce an `AssertionError` using documented public functions, that
is by definition a bug.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12407#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
