#13723: Moving hamming_weight from sage.coding to sage.modules
-------------------------------------------------+--------------------------
Reporter: tfeulner | Owner: wdj
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.6
Component: coding theory | Resolution:
Keywords: Hamming weight, coding theory | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Thomas Feulner | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by tfeulner):
Replying to [comment:3 ppurka]:
> Ok. I missed the fact that you haven't removed it from global scope.
>
> There are three comments I have about the patch (sorry for nitpicking
:)):
It is ok, I learned a lot from those comments.
> 1. It is missing the hg headers containing your name and other
information. Maybe you don't have a hgrc? Also, the patch should have the
ticket number in its name (like `trac_13723-hamming_weight.patch` or
`13273-hamming_weight.patch`). If I am not mistaken Jeroen has some script
which parses the patch name to get the ticket number. Since you have
already made this patch, you can simply rename it using hg like
> {{{
> $ cd <sage_root>/devel/sage
> $ hg qmv hamming_weight_simplex_code.patch
trac_13723-hamming_weight.patch
> -- OR if you don't have hg installed in your system --
> $ sage -hg qmv hamming_weight_simplex_code.patch
trac_13723-hamming_weight.patch
> }}}
I think it contains all the information now, I worked with hg_sage and for
some reason this information was not added.
> 2. In the example in `vector_mod2_dense.pyx` file, the answer should be
2.
Of course, thanks.
> 3. Can you fix the `type(v) == list` statements with `isinstance(v,
list)`? It is not your mistake, but it would be nice to have them fixed.
Done.
>
> Otherwise the patch looks fine to me.
Thanks again, are there other comments?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13723#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
