#13723: Moving hamming_weight from sage.coding to sage.modules
-------------------------------------------------+--------------------------
Reporter: tfeulner | Owner: wdj
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.5
Component: coding theory | Resolution:
Keywords: Hamming weight, coding theory | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu
Purkayastha
Authors: Thomas Feulner | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------+--------------------------
Changes (by tscrim):
* status: positive_review => needs_work
* reviewer: => Punarbasu Purkayastha
Comment:
Sorry but it's my turn to be nitpicking. There's some documentation things
I would like to see addressed:
- It should be {{{:trac:`13723`}}}, the `#` is added automatically and as
you have it written, the link is incorrect as it includes the `#`.
- I prefer to see everything set it code format/linked as much as
possible:
- In the authors section: {{{Added :meth:`CLASSNAME.hamming_weight`}}}
or {{{Added ``hamming_weight()``}}}
- Change all appropriate lines:
{{{
Return the number of positions ``i`` such that ``self[i] != 0``.
}}}
- I don't like the deprecation message. Perhaps something like
{{{
The global function hamming_weight(v) is deprecated, instead use
v.hamming_weight().
}}}
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13723#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
