#13727: Minor improvements for dict_addition
----------------------------------+-----------------------------------------
       Reporter:  stumpc5         |         Owner:  sage-combinat
           Type:  enhancement     |        Status:  needs_review 
       Priority:  major           |     Milestone:  sage-5.6     
      Component:  combinatorics   |    Resolution:               
       Keywords:  dict, addition  |   Work issues:               
Report Upstream:  N/A             |     Reviewers:               
        Authors:                  |     Merged in:               
   Dependencies:                  |      Stopgaps:               
----------------------------------+-----------------------------------------

Comment (by chapoton):

 The patch looks good. I have some minor comments on the documentation :

 - the sentences " a dictionary containing all keys of dictionaries in
 ``dict_list`` (and non-zero values) being the sum of the values in the
 different dictionaries. "

 are not extra-clear. Maybe something like that would be more clear :

 a dictionary containing all keys of dictionaries in ``dict_list``, with
 values being the sum of the values in the different dictionaries (keys
 with zero value are omitted)

 - if you use :param x:, maybe you need to write r""" at the beginning of
 the doc ?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13727#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to