#5294: Pickle Jar documentation
--------------------------------------------+-------------------------------
       Reporter:  hivert                    |         Owner:  andrew.mathas
           Type:  defect                    |        Status:  needs_review 
       Priority:  major                     |     Milestone:  sage-5.5     
      Component:  documentation             |    Resolution:               
       Keywords:  picklejar, documentation  |   Work issues:               
Report Upstream:  N/A                       |     Reviewers:  Julian Rueth 
        Authors:  Andrew Mathas             |     Merged in:               
   Dependencies:                            |      Stopgaps:               
--------------------------------------------+-------------------------------
Changes (by saraedum):

  * reviewer:  => Julian Rueth


Comment:

 A very valuable addition to the documentation!

 I think I found two minor issues though:

 * In the excerpt from the python docs about
 {{{object.__setstate__(state)}}} you lost some underscores (it should say
 {{{__setstate__}}} and not {{{setstate__}}}.)
 * You should probably remove the trailing whitespace in the
 {{{__reduce__}}} function that the patchbot complains about

 Btw., the patchbot coverage plugin complains that you added one method
 without a doctest. But this is actually just, the {{{__reduce___}}} method
 in the docstring.

 I don't have the time to look at the html version of the documentation
 now, I'll do that soon, write a review patch with the above two points,
 and set it to positive review.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5294#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to