#8327: Implement the universal cyclotomic field, using Zumbroich basis
-----------------------------------------------------+----------------------
Reporter: nthiery | Owner:
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.6
Component: number fields | Resolution:
Keywords: Cyclotomic field, Zumbroich basis | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Christian Stump, Simon King | Merged in:
Dependencies: #13727, #13728 | Stopgaps:
-----------------------------------------------------+----------------------
Comment (by stumpc5):
Replying to [comment:121 chapoton]:
> A few more comments
Thanks a lot!
> * the sort of elements is backwards compared to the order for cyclotomic
fields
> maybe it would be better to go the same way ? but maybe this is the same
as gap ?
I used the same order as gap (the increasing ordering on the exponents). I
think I would prefer this ordering...
> * Is the is_subring method necessary ? it is almost empty !
I don't quite remember where but I needed this (indeed trivially
implemented) method at some point to not catch an error. Maybe it was when
working with matrices over UCF?
> "no coercion found for elements of XXX"
done, I had to distinguish between objects having a parent and those not
having one.
> * maybe zumbroich_basis should be called zumbroich_basis_indices ? I
would expect that something called zumbroich_basis would return elements
of the field, which is not really the case. Well, this is not that
important..
done
> * why is the hash function test tagged with random ? does it depend on
the computer or something like that ?
If I am not mistaken, the hash is only unique in a given Sage session.
> * in _invert_, one should rather raise a ZeroDivisionError when trying
to invert 0 ?
> * more generally, maybe one could try to avoid using assert, and better
raise precise Exceptions ?
good point, done!
Best, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8327#comment:122>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
