#13731: Fix libsingular memory management
------------------------------------------------------------------+---------
Reporter: nbruin |
Owner: rlm
Type: defect |
Status: new
Priority: major |
Milestone: sage-5.6
Component: memleak |
Resolution:
Keywords: | Work
issues:
Report Upstream: Reported upstream. Developers acknowledge bug. |
Reviewers:
Authors: | Merged
in:
Dependencies: |
Stopgaps:
------------------------------------------------------------------+---------
Comment (by SimonKing):
Now I try to patch the standard Singular spkg so that one can
''optionally'' use malloc. But I have two questions on how you created the
singular-malloc spkg.
Recall that I have removed (or at least I tried to remove) all auto-
generated files that I found in your spkg in order to make it work on my
`openSuse` laptop. The changes compared with the original sources are:
{{{
M src/Singular/Makefile.in
M src/Singular/Minor.h
M src/Singular/configure
M src/Singular/configure.in
M src/Singular/sing_win.cc
M src/factory/assert.h
M src/factory/cf_chinese.cc
M src/factory/cf_util.cc
M src/factory/cf_util.h
M src/factory/facBivar.h
M src/factory/facFactorize.h
M src/factory/facFqBivar.cc
M src/omalloc/Makefile.in
M src/omalloc/omAllocDecl.h
M src/omalloc/omAllocFunc.c
M src/omalloc/omMallocSystem.h
M src/omalloc/omalloc.c
M src/omalloc/pmalloc.h
? src/factory/gen_cf_gmp.sh
? src/omalloc/omTables.h
? src/omalloc/omTables.inc
}}}
So, first question: Is it correct that all three new files are needed for
malloc support? I'd rather think that `gen_cf_gmp.sh` should not be here,
because it contains explicit paths:
{{{
#!/bin/sh
GMP_H_T="gen_cf_gmp.o: gen_cf_gmp.cc
/usr/local/sage/5.5b1/local/include/gmp.h \ "
GMP_H=`echo $GMP_H_T| sed -e 's/^.*gmp.cc//' -e 's/ .$//'`
echo generating cf_gmp.h from $GMP_H
cat $GMP_H | grep -v __GMP_DECLSPEC_XX |grep -v std::FILE > cf_gmp.h
}}}
Second question: Is it not the case that `src/Singular/configure` is auto-
generated from `src/Singular/configure.in`? Or is it really essential that
`src/Singular/configure` is as in your spkg?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13731#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
