#13731: Fix libsingular memory management
--------------------------------------------------------------+-------------
Reporter: nbruin | Owner:
rlm
Type: defect | Status:
new
Priority: major | Milestone:
sage-5.6
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Authors: Nils Bruin, Simon King | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by nbruin):
Concerning the packaging of `xalloc` in the singular package. Presently:
{{{
$ ls -l /tmp/singular_xalloc.patch
-r--------. 1 847572 Dec 1 10:05 /tmp/singular_xalloc.patch
$ grep '^-' /tmp/singular_xalloc.patch |wc
26089 106795 824416
$ grep '^+' /tmp/singular_xalloc.patch |wc
374 1168 10286
}}}
so it's a large patch: 800kB on 8MB for the spkg. I guess it'll compress
well, so the ration is not quite 10%, but still: The patch mainly consists
of exactly listing all the files in the `omalloc` directory in order to
delete them. That means that we're now shipping `omalloc` twice in order
to be able to remove it.
I propose to code the patch differently:
- put xalloc into its own subdir; inside next to `omalloc` probably. You
can do this by patch or something else.
- If `SINGULAR_XALLOC` is `yes`, do explicit `mv` and or `ln -s` commands
to more the original `omalloc` out of the way and replace it by `xalloc`
- the changes to the singular source itself should of course remain in
the patch file.
Perhaps it's not according to the letter of "use patch to change src", but
patch is just inappropriate for a `rip out and replace` operation like
this.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13731#comment:116>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
