#5537: [with patch, mostly positive review] bug in __cmp__ in
permgroup_element.pyx
--------------------------+-------------------------------------------------
Reporter: jhpalmieri | Owner: robertwb
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.2
Component: group_theory | Keywords:
--------------------------+-------------------------------------------------
Comment(by jhpalmieri):
I don't like having all of the < and > tests without documentation. I
think in the old code, < and > didn't really mean anything, whereas now
they do. I also don't like the examples that were in the old code: things
like {{{G.gen(0) < G.gen(1)}}}. This is not very helpful to the user
unless they first evaluate G.gen(0) and G.gen(1). So I've changed the
docstring a bit in a referee's patch.
Also, a very minor point, but I think that in
{{{
TESTS::
Verify that we fixed bug #5537::
}}}
there should be only one colon after TESTS. This isn't really important
because right now, methods starting with an underscore don't appear in the
reference manual, but I hope that some day they might... I changed this,
too.
Meanwhile, the patch fixes the problem in the summary and also the problem
that rbeezer reports. All tests pass. If my patch is acceptable,
positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5537#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
