#4637: [with patch, with positive review] bug/stupid design of
padic_printing.sep
print mode stuff
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.2
Component: number theory | Keywords:
---------------------------+------------------------------------------------
Comment(by ncalexan):
I'll be honest, this is ugly beyond belief.
Why isn't this printing functionality factored out into a separate
printing object which is then part of the data for the ring? For example,
we now have a boatload of printing parameters... sounds like an object to
me. We have, for example, a {{{name}}} and a {{{ram_name}}}; for
something like {{{Zq(5^2, 'a')}}} {{{name}}} is 'a' and one could make 5
print as {{{ram_name}}}, often 'p'. But what happens when we have two
level extensions, rather than just one level?
Why aren't we constructing {{{Zp}}} first, setting its printing, and then
constructing {{{Zq}}} on top of that {{{Zp}}}?
I am reviewing this positive because:
* it passes doctests;
* it appears to fix at least one of the bugs at hand;
* it adds valuable documentation and tests;
* and, most importantly, is a step in the direction the maintainer, David
Roe, wants the code to progress.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4637#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
