#13324: Upgrade ECL to 12.7.1 and let it build on (recent) Cygwins
----------------------------------------------------------------+-----------
Reporter: jpflori |
Owner: tbd
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.6
Component: cygwin |
Resolution:
Keywords: cygwin ecl spkg | Work
issues:
Report Upstream: Fixed upstream, but not in a stable release. |
Reviewers: François Bissey
Authors: Jean-Pierre Flori | Merged
in:
Dependencies: |
Stopgaps:
----------------------------------------------------------------+-----------
Old description:
> On my 1.7.16 installation of Cygwin, the ecl spkg does not build because
> it defines unconditionaly _WINSOCKAPI_ in h/ecl-cmp.h which then prevents
> the definition of fd_set in /usr/include/sys/types.h.
> I guess this is harmless on Linux, intended on Windows, but on Cygwin
> this breaks the build of ECL.
>
> The proposed spkg patches h/ecl-cmp.h so that _WINSOCKAPI_ is not defined
> on CYGWIN.
> This has been merged upstream:
> https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/
>
> Moreover comes patches from upstream to get correct signal handling [in
> single threaded mode]:
> *
> http://sourceforge.net/p/ecls/ecl/ci/c4a538dd278407f91f6105ebbeadf1b371c1124f/
> *
> http://sourceforge.net/p/ecls/ecl/ci/15033d5a8ad7297e5f76e2e70446b0eea2f2d2a7/
> *
> http://sourceforge.net/p/ecls/ecl/ci/ec1fe8781a5f137284cc6c0d0cfa6b0cc9b9b291/
>
> We build ECL single threaded to get hopefully more correct signal
> handling in library mode and avoid problems with the pexpect interface.
>
> Try spkg at
> http://boxen.math.washington.edu/home/jpflori/ecl-12.7.1.p0.spkg
> which includes upstream version 12.7.1 and the above fixes.
>
> Apply:
> * [attachment:trac_13324.patch].
New description:
On my 1.7.16 installation of Cygwin, the ecl spkg does not build because
it defines unconditionaly _WINSOCKAPI_ in h/ecl-cmp.h which then prevents
the definition of fd_set in /usr/include/sys/types.h.
I guess this is harmless on Linux, intended on Windows, but on Cygwin this
breaks the build of ECL.
The proposed spkg patches h/ecl-cmp.h so that _WINSOCKAPI_ is not defined
on CYGWIN.
This has been merged upstream:
https://sourceforge.net/p/ecls/ecl/ci/07c4ab7db83eda2eed7fa4a5ddeec2e28c7eb58b/
Moreover comes patches from upstream to get correct signal handling [in
single threaded mode]:
*
http://sourceforge.net/p/ecls/ecl/ci/c4a538dd278407f91f6105ebbeadf1b371c1124f/
*
http://sourceforge.net/p/ecls/ecl/ci/15033d5a8ad7297e5f76e2e70446b0eea2f2d2a7/
*
http://sourceforge.net/p/ecls/ecl/ci/ec1fe8781a5f137284cc6c0d0cfa6b0cc9b9b291/
We build ECL single threaded to get hopefully more correct signal handling
in library mode and avoid problems with the pexpect interface.
Try spkg at
http://boxen.math.washington.edu/home/jpflori/ecl-12.7.1.p0.spkg
which includes upstream version 12.7.1 and the above fixes.
Or rather use the spkg including the newly released ECL:
http://boxen.math.washington.edu/home/jpflori/ecl-12.12.1.p0.spkg
Apply:
* [attachment:trac_13324.patch].
--
Comment (by jpflori):
Tentative updated spkg at
http://boxen.math.washington.edu/home/jpflori/ecl-12.12.1.p0.spkg
I guess it would be more sensible to get this new spkg into Sage.
On the Sage side, the only changes are that I removed the two patches
backported for 12.7.1.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13324#comment:60>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
